Orange Pi5 kernel

Deprecated Linux kernel 5.10.110 for OrangePi 5/5B/5+ boards

3 Commits   0 Branches   0 Tags
// SPDX-License-Identifier: GPL-2.0
/* Copyright (c) 2019 Fuzhou Rockchip Electronics Co., Ltd. */

#include <media/v4l2-common.h>
#include <media/v4l2-ioctl.h>
#include <media/videobuf2-core.h>
#include <media/videobuf2-vmalloc.h>	/* for ISP params */
#include <linux/rk-preisp.h>
#include "dev.h"
#include "regs.h"
#include "isp_params_v1x.h"

#define RKISP1_ISP_PARAMS_REQ_BUFS_MIN	2
#define RKISP1_ISP_PARAMS_REQ_BUFS_MAX	8

#define BLS_START_H_MAX_IS_VALID(val)	((val) < CIFISP_BLS_START_H_MAX)
#define BLS_STOP_H_MAX_IS_VALID(val)	((val) < CIFISP_BLS_STOP_H_MAX)

#define BLS_START_V_MAX_IS_VALID(val)	((val) < CIFISP_BLS_START_V_MAX)
#define BLS_STOP_V_MAX_IS_VALID(val)	((val) < CIFISP_BLS_STOP_V_MAX)

#define BLS_SAMPLE_MAX_IS_VALID(val)	((val) < CIFISP_BLS_SAMPLES_MAX)

#define BLS_FIX_SUB_IS_VALID(val) \
	((val) > (s16)CIFISP_BLS_FIX_SUB_MIN && (val) < CIFISP_BLS_FIX_SUB_MAX)

#define RKISP1_ISP_DPCC_LINE_THRESH(n)	(CIF_ISP_DPCC_LINE_THRESH_1 + 0x14 * (n))
#define RKISP1_ISP_DPCC_LINE_MAD_FAC(n) (CIF_ISP_DPCC_LINE_MAD_FAC_1 + 0x14 * (n))
#define RKISP1_ISP_DPCC_PG_FAC(n)	(CIF_ISP_DPCC_PG_FAC_1 + 0x14 * (n))
#define RKISP1_ISP_DPCC_RND_THRESH(n)	(CIF_ISP_DPCC_RND_THRESH_1 + 0x14 * (n))
#define RKISP1_ISP_DPCC_RG_FAC(n)	(CIF_ISP_DPCC_RG_FAC_1 + 0x14 * (n))
#define RKISP1_ISP_CC_COEFF(n)		(CIF_ISP_CC_COEFF_0 + (n) * 4)

static inline void rkisp1_iowrite32(struct rkisp_isp_params_vdev *params_vdev,
				    u32 value, u32 addr)
{
	iowrite32(value, params_vdev->dev->base_addr + addr);
}

static inline u32 rkisp1_ioread32(struct rkisp_isp_params_vdev *params_vdev,
				  u32 addr)
{
	return ioread32(params_vdev->dev->base_addr + addr);
}

/* ISP BP interface function */
static void isp_dpcc_config(struct rkisp_isp_params_vdev *params_vdev,
			    const struct cifisp_dpcc_config *arg)
{
	unsigned int i;
	u32 mode;

	/* avoid to override the old enable value */
	mode = rkisp1_ioread32(params_vdev, CIF_ISP_DPCC_MODE);
	mode &= CIF_ISP_DPCC_ENA;
	mode |= arg->mode & ~CIF_ISP_DPCC_ENA;
	rkisp1_iowrite32(params_vdev, mode, CIF_ISP_DPCC_MODE);
	rkisp1_iowrite32(params_vdev, arg->output_mode,
			 CIF_ISP_DPCC_OUTPUT_MODE);
	rkisp1_iowrite32(params_vdev, arg->set_use, CIF_ISP_DPCC_SET_USE);

	rkisp1_iowrite32(params_vdev, arg->methods[0].method,
			 CIF_ISP_DPCC_METHODS_SET_1);
	rkisp1_iowrite32(params_vdev, arg->methods[1].method,
			 CIF_ISP_DPCC_METHODS_SET_2);
	rkisp1_iowrite32(params_vdev, arg->methods[2].method,
			 CIF_ISP_DPCC_METHODS_SET_3);
	for (i = 0; i < CIFISP_DPCC_METHODS_MAX; i++) {
		rkisp1_iowrite32(params_vdev, arg->methods[i].line_thresh,
				 RKISP1_ISP_DPCC_LINE_THRESH(i));
		rkisp1_iowrite32(params_vdev, arg->methods[i].line_mad_fac,
				 RKISP1_ISP_DPCC_LINE_MAD_FAC(i));
		rkisp1_iowrite32(params_vdev, arg->methods[i].pg_fac,
				 RKISP1_ISP_DPCC_PG_FAC(i));
		rkisp1_iowrite32(params_vdev, arg->methods[i].rnd_thresh,
				 RKISP1_ISP_DPCC_RND_THRESH(i));
		rkisp1_iowrite32(params_vdev, arg->methods[i].rg_fac,
				 RKISP1_ISP_DPCC_RG_FAC(i));
	}

	rkisp1_iowrite32(params_vdev, arg->rnd_offs, CIF_ISP_DPCC_RND_OFFS);
	rkisp1_iowrite32(params_vdev, arg->ro_limits, CIF_ISP_DPCC_RO_LIMITS);
}

/* ISP black level subtraction interface function */
static void isp_bls_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_bls_config *arg)
{
	/* avoid to override the old enable value */
	u32 new_control;

	new_control = rkisp1_ioread32(params_vdev, CIF_ISP_BLS_CTRL);
	new_control &= CIF_ISP_BLS_ENA;
	/* fixed subtraction values */
	if (!arg->enable_auto) {
		const struct cifisp_bls_fixed_val *pval = &arg->fixed_val;

		switch (params_vdev->raw_type) {
		case RAW_BGGR:
			rkisp1_iowrite32(params_vdev,
					 pval->r, CIF_ISP_BLS_D_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gr, CIF_ISP_BLS_C_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gb, CIF_ISP_BLS_B_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->b, CIF_ISP_BLS_A_FIXED);
			break;
		case RAW_GBRG:
			rkisp1_iowrite32(params_vdev,
					 pval->r, CIF_ISP_BLS_C_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gr, CIF_ISP_BLS_D_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gb, CIF_ISP_BLS_A_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->b, CIF_ISP_BLS_B_FIXED);
			break;
		case RAW_GRBG:
			rkisp1_iowrite32(params_vdev,
					 pval->r, CIF_ISP_BLS_B_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gr, CIF_ISP_BLS_A_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gb, CIF_ISP_BLS_D_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->b, CIF_ISP_BLS_C_FIXED);
			break;
		case RAW_RGGB:
			rkisp1_iowrite32(params_vdev,
					 pval->r, CIF_ISP_BLS_A_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gr, CIF_ISP_BLS_B_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->gb, CIF_ISP_BLS_C_FIXED);
			rkisp1_iowrite32(params_vdev,
					 pval->b, CIF_ISP_BLS_D_FIXED);
			break;
		default:
			break;
		}

	} else {
		if (arg->en_windows & BIT(1)) {
			rkisp1_iowrite32(params_vdev, arg->bls_window2.h_offs,
					 CIF_ISP_BLS_H2_START);
			rkisp1_iowrite32(params_vdev, arg->bls_window2.h_size,
					 CIF_ISP_BLS_H2_STOP);
			rkisp1_iowrite32(params_vdev, arg->bls_window2.v_offs,
					 CIF_ISP_BLS_V2_START);
			rkisp1_iowrite32(params_vdev, arg->bls_window2.v_size,
					 CIF_ISP_BLS_V2_STOP);
			new_control |= CIF_ISP_BLS_WINDOW_2;
		}

		if (arg->en_windows & BIT(0)) {
			rkisp1_iowrite32(params_vdev, arg->bls_window1.h_offs,
					 CIF_ISP_BLS_H1_START);
			rkisp1_iowrite32(params_vdev, arg->bls_window1.h_size,
					 CIF_ISP_BLS_H1_STOP);
			rkisp1_iowrite32(params_vdev, arg->bls_window1.v_offs,
					 CIF_ISP_BLS_V1_START);
			rkisp1_iowrite32(params_vdev, arg->bls_window1.v_size,
					 CIF_ISP_BLS_V1_STOP);
			new_control |= CIF_ISP_BLS_WINDOW_1;
		}

		rkisp1_iowrite32(params_vdev, arg->bls_samples,
				 CIF_ISP_BLS_SAMPLES);

		new_control |= CIF_ISP_BLS_MODE_MEASURED;
	}
	rkisp1_iowrite32(params_vdev, new_control, CIF_ISP_BLS_CTRL);
}

/* ISP LS correction interface function */
static void
isp_lsc_matrix_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			  const struct cifisp_lsc_config *pconfig)
{
	int i, j;
	unsigned int isp_lsc_status, sram_addr, isp_lsc_table_sel;
	unsigned int data;

	isp_lsc_status = rkisp1_ioread32(params_vdev, CIF_ISP_LSC_STATUS);

	/* CIF_ISP_LSC_TABLE_ADDRESS_153 = ( 17 * 18 ) >> 1 */
	sram_addr = (isp_lsc_status & CIF_ISP_LSC_ACTIVE_TABLE) ?
		     CIF_ISP_LSC_TABLE_ADDRESS_0 :
		     CIF_ISP_LSC_TABLE_ADDRESS_153;
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_R_TABLE_ADDR);
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_GR_TABLE_ADDR);
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_GB_TABLE_ADDR);
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_B_TABLE_ADDR);

	/* program data tables (table size is 9 * 17 = 153) */
	for (i = 0; i < CIF_ISP_LSC_SECTORS_MAX * CIF_ISP_LSC_SECTORS_MAX;
	     i += CIF_ISP_LSC_SECTORS_MAX) {
		/*
		 * 17 sectors with 2 values in one DWORD = 9
		 * DWORDs (2nd value of last DWORD unused)
		 */
		for (j = 0; j < CIF_ISP_LSC_SECTORS_MAX - 1; j += 2) {
			data = CIF_ISP_LSC_TABLE_DATA_V10(
					pconfig->r_data_tbl[i + j],
					pconfig->r_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_R_TABLE_DATA);

			data = CIF_ISP_LSC_TABLE_DATA_V10(
					pconfig->gr_data_tbl[i + j],
					pconfig->gr_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_GR_TABLE_DATA);

			data = CIF_ISP_LSC_TABLE_DATA_V10(
					pconfig->gb_data_tbl[i + j],
					pconfig->gb_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_GB_TABLE_DATA);

			data = CIF_ISP_LSC_TABLE_DATA_V10(
					pconfig->b_data_tbl[i + j],
					pconfig->b_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_B_TABLE_DATA);
		}

		data = CIF_ISP_LSC_TABLE_DATA_V10(
				pconfig->r_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_R_TABLE_DATA);

		data = CIF_ISP_LSC_TABLE_DATA_V10(
				pconfig->gr_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_GR_TABLE_DATA);

		data = CIF_ISP_LSC_TABLE_DATA_V10(
				pconfig->gb_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_GB_TABLE_DATA);

		data = CIF_ISP_LSC_TABLE_DATA_V10(
				pconfig->b_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_B_TABLE_DATA);
	}
	isp_lsc_table_sel = (isp_lsc_status & CIF_ISP_LSC_ACTIVE_TABLE) ?
				CIF_ISP_LSC_TABLE_0 : CIF_ISP_LSC_TABLE_1;
	rkisp1_iowrite32(params_vdev, isp_lsc_table_sel, CIF_ISP_LSC_TABLE_SEL);
}

static void
isp_lsc_matrix_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			  const struct cifisp_lsc_config *pconfig)
{
	int i, j;
	unsigned int isp_lsc_status, sram_addr, isp_lsc_table_sel;
	unsigned int data;

	isp_lsc_status = rkisp1_ioread32(params_vdev, CIF_ISP_LSC_STATUS);

	/* CIF_ISP_LSC_TABLE_ADDRESS_153 = ( 17 * 18 ) >> 1 */
	sram_addr = (isp_lsc_status & CIF_ISP_LSC_ACTIVE_TABLE) ?
		     CIF_ISP_LSC_TABLE_ADDRESS_0 :
		     CIF_ISP_LSC_TABLE_ADDRESS_153;
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_R_TABLE_ADDR);
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_GR_TABLE_ADDR);
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_GB_TABLE_ADDR);
	rkisp1_iowrite32(params_vdev, sram_addr, CIF_ISP_LSC_B_TABLE_ADDR);

	/* program data tables (table size is 9 * 17 = 153) */
	for (i = 0; i < CIF_ISP_LSC_SECTORS_MAX * CIF_ISP_LSC_SECTORS_MAX;
	     i += CIF_ISP_LSC_SECTORS_MAX) {
		/*
		 * 17 sectors with 2 values in one DWORD = 9
		 * DWORDs (2nd value of last DWORD unused)
		 */
		for (j = 0; j < CIF_ISP_LSC_SECTORS_MAX - 1; j += 2) {
			data = CIF_ISP_LSC_TABLE_DATA_V12(
					pconfig->r_data_tbl[i + j],
					pconfig->r_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_R_TABLE_DATA);

			data = CIF_ISP_LSC_TABLE_DATA_V12(
					pconfig->gr_data_tbl[i + j],
					pconfig->gr_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_GR_TABLE_DATA);

			data = CIF_ISP_LSC_TABLE_DATA_V12(
					pconfig->gb_data_tbl[i + j],
					pconfig->gb_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_GB_TABLE_DATA);

			data = CIF_ISP_LSC_TABLE_DATA_V12(
					pconfig->b_data_tbl[i + j],
					pconfig->b_data_tbl[i + j + 1]);
			rkisp1_iowrite32(params_vdev, data,
					 CIF_ISP_LSC_B_TABLE_DATA);
		}

		data = CIF_ISP_LSC_TABLE_DATA_V12(
				pconfig->r_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_R_TABLE_DATA);

		data = CIF_ISP_LSC_TABLE_DATA_V12(
				pconfig->gr_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_GR_TABLE_DATA);

		data = CIF_ISP_LSC_TABLE_DATA_V12(
				pconfig->gb_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_GB_TABLE_DATA);

		data = CIF_ISP_LSC_TABLE_DATA_V12(
				pconfig->b_data_tbl[i + j],
				0);
		rkisp1_iowrite32(params_vdev, data,
				CIF_ISP_LSC_B_TABLE_DATA);
	}
	isp_lsc_table_sel = (isp_lsc_status & CIF_ISP_LSC_ACTIVE_TABLE) ?
				CIF_ISP_LSC_TABLE_0 : CIF_ISP_LSC_TABLE_1;
	rkisp1_iowrite32(params_vdev, isp_lsc_table_sel, CIF_ISP_LSC_TABLE_SEL);
}

static void isp_lsc_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_lsc_config *arg)
{
	int i;
	u32 lsc_ctrl;
	unsigned int data;
	struct rkisp_isp_params_v1x_ops *ops =
		(struct rkisp_isp_params_v1x_ops *)params_vdev->priv_ops;

	/* To config must be off , store the current status firstly */
	lsc_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_LSC_CTRL);
	isp_param_clear_bits(params_vdev, CIF_ISP_LSC_CTRL,
			     CIF_ISP_LSC_CTRL_ENA);
	ops->lsc_matrix_config(params_vdev, arg);

	for (i = 0; i < 4; i++) {
		/* program x size tables */
		data = CIF_ISP_LSC_SECT_SIZE(arg->x_size_tbl[i * 2],
					arg->x_size_tbl[i * 2 + 1]);
		rkisp1_iowrite32(params_vdev, data,
				 CIF_ISP_LSC_XSIZE_01 + i * 4);

		/* program x grad tables */
		data = CIF_ISP_LSC_SECT_SIZE(arg->x_grad_tbl[i * 2],
					arg->x_grad_tbl[i * 2 + 1]);
		rkisp1_iowrite32(params_vdev, data,
				 CIF_ISP_LSC_XGRAD_01 + i * 4);

		/* program y size tables */
		data = CIF_ISP_LSC_SECT_SIZE(arg->y_size_tbl[i * 2],
					arg->y_size_tbl[i * 2 + 1]);
		rkisp1_iowrite32(params_vdev, data,
				 CIF_ISP_LSC_YSIZE_01 + i * 4);

		/* program y grad tables */
		data = CIF_ISP_LSC_SECT_SIZE(arg->y_grad_tbl[i * 2],
					arg->y_grad_tbl[i * 2 + 1]);
		rkisp1_iowrite32(params_vdev, data,
				 CIF_ISP_LSC_YGRAD_01 + i * 4);
	}

	/* restore the lsc ctrl status */
	if (lsc_ctrl & CIF_ISP_LSC_CTRL_ENA) {
		isp_param_set_bits(params_vdev,
				   CIF_ISP_LSC_CTRL,
				   CIF_ISP_LSC_CTRL_ENA);
	} else {
		isp_param_clear_bits(params_vdev,
				     CIF_ISP_LSC_CTRL,
				     CIF_ISP_LSC_CTRL_ENA);
	}
}

/* ISP Filtering function */
static void isp_flt_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_flt_config *arg)
{
	u32 filt_mode;

	rkisp1_iowrite32(params_vdev, arg->thresh_bl0, CIF_ISP_FILT_THRESH_BL0);
	rkisp1_iowrite32(params_vdev, arg->thresh_bl1, CIF_ISP_FILT_THRESH_BL1);
	rkisp1_iowrite32(params_vdev, arg->thresh_sh0, CIF_ISP_FILT_THRESH_SH0);
	rkisp1_iowrite32(params_vdev, arg->thresh_sh1, CIF_ISP_FILT_THRESH_SH1);
	rkisp1_iowrite32(params_vdev, arg->fac_bl0, CIF_ISP_FILT_FAC_BL0);
	rkisp1_iowrite32(params_vdev, arg->fac_bl1, CIF_ISP_FILT_FAC_BL1);
	rkisp1_iowrite32(params_vdev, arg->fac_mid, CIF_ISP_FILT_FAC_MID);
	rkisp1_iowrite32(params_vdev, arg->fac_sh0, CIF_ISP_FILT_FAC_SH0);
	rkisp1_iowrite32(params_vdev, arg->fac_sh1, CIF_ISP_FILT_FAC_SH1);
	rkisp1_iowrite32(params_vdev, arg->lum_weight, CIF_ISP_FILT_LUM_WEIGHT);

	/* avoid to override the old enable value */
	filt_mode = rkisp1_ioread32(params_vdev, CIF_ISP_FILT_MODE);
	filt_mode &= CIF_ISP_FLT_ENA;
	if (arg->mode)
		filt_mode |= CIF_ISP_FLT_MODE_DNR;
	filt_mode |= CIF_ISP_FLT_CHROMA_V_MODE(arg->chr_v_mode) |
				 CIF_ISP_FLT_CHROMA_H_MODE(arg->chr_h_mode) |
				 CIF_ISP_FLT_GREEN_STAGE1(arg->grn_stage1);
	rkisp1_iowrite32(params_vdev, filt_mode, CIF_ISP_FILT_MODE);
}

/* ISP demosaic interface function */
static void isp_bdm_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_bdm_config *arg)
{
	u32 bdm_th;

	/* avoid to override the old enable value */
	bdm_th = rkisp1_ioread32(params_vdev, CIF_ISP_DEMOSAIC);
	bdm_th &= CIF_ISP_DEMOSAIC_BYPASS;
	bdm_th |= arg->demosaic_th & ~CIF_ISP_DEMOSAIC_BYPASS;
	/* set demosaic threshold */
	rkisp1_iowrite32(params_vdev, bdm_th, CIF_ISP_DEMOSAIC);
}

/* ISP GAMMA correction interface function */
static void isp_sdg_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_sdg_config *arg)
{
	int i;

	rkisp1_iowrite32(params_vdev,
			 arg->xa_pnts.gamma_dx0, CIF_ISP_GAMMA_DX_LO);
	rkisp1_iowrite32(params_vdev,
			 arg->xa_pnts.gamma_dx1, CIF_ISP_GAMMA_DX_HI);

	for (i = 0; i < CIFISP_DEGAMMA_CURVE_SIZE; i++) {
		rkisp1_iowrite32(params_vdev, arg->curve_r.gamma_y[i],
				 CIF_ISP_GAMMA_R_Y0 + i * 4);
		rkisp1_iowrite32(params_vdev, arg->curve_g.gamma_y[i],
				 CIF_ISP_GAMMA_G_Y0 + i * 4);
		rkisp1_iowrite32(params_vdev, arg->curve_b.gamma_y[i],
				 CIF_ISP_GAMMA_B_Y0 + i * 4);
	}
}

/* ISP GAMMA correction interface function */
static void isp_goc_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_goc_config *arg)
{
	int i;
	struct rkisp_isp_params_v1x_config *config =
		(struct rkisp_isp_params_v1x_config *)params_vdev->priv_cfg;

	rkisp1_iowrite32(params_vdev, arg->mode, CIF_ISP_GAMMA_OUT_MODE_V10);

	for (i = 0; i < config->gamma_out_max_samples; i++)
		rkisp1_iowrite32(params_vdev, arg->gamma_y[i],
				 CIF_ISP_GAMMA_OUT_Y_0_V10 + i * 4);
}

static void isp_goc_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_goc_config *arg)
{
	int i;
	u32 value;
	struct rkisp_isp_params_v1x_config *config =
		(struct rkisp_isp_params_v1x_config *)params_vdev->priv_cfg;

	rkisp1_iowrite32(params_vdev, arg->mode, CIF_ISP_GAMMA_OUT_MODE_V12);

	for (i = 0; i < config->gamma_out_max_samples / 2; i++) {
		value = CIF_ISP_GAMMA_REG_VALUE_V12(
			arg->gamma_y[2 * i + 1],
			arg->gamma_y[2 * i]);
		rkisp1_iowrite32(params_vdev, value,
				 CIF_ISP_GAMMA_OUT_Y_0_V12 + i * 4);
	}
}

/* ISP Cross Talk */
static void isp_ctk_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_ctk_config *arg)
{
	rkisp1_iowrite32(params_vdev, arg->coeff0, CIF_ISP_CT_COEFF_0);
	rkisp1_iowrite32(params_vdev, arg->coeff1, CIF_ISP_CT_COEFF_1);
	rkisp1_iowrite32(params_vdev, arg->coeff2, CIF_ISP_CT_COEFF_2);
	rkisp1_iowrite32(params_vdev, arg->coeff3, CIF_ISP_CT_COEFF_3);
	rkisp1_iowrite32(params_vdev, arg->coeff4, CIF_ISP_CT_COEFF_4);
	rkisp1_iowrite32(params_vdev, arg->coeff5, CIF_ISP_CT_COEFF_5);
	rkisp1_iowrite32(params_vdev, arg->coeff6, CIF_ISP_CT_COEFF_6);
	rkisp1_iowrite32(params_vdev, arg->coeff7, CIF_ISP_CT_COEFF_7);
	rkisp1_iowrite32(params_vdev, arg->coeff8, CIF_ISP_CT_COEFF_8);
	rkisp1_iowrite32(params_vdev, arg->ct_offset_r, CIF_ISP_CT_OFFSET_R);
	rkisp1_iowrite32(params_vdev, arg->ct_offset_g, CIF_ISP_CT_OFFSET_G);
	rkisp1_iowrite32(params_vdev, arg->ct_offset_b, CIF_ISP_CT_OFFSET_B);
}

static void isp_ctk_enable(struct rkisp_isp_params_vdev *params_vdev, bool en)
{
	if (en)
		return;

	/* Write back the default values. */
	rkisp1_iowrite32(params_vdev, 0x80, CIF_ISP_CT_COEFF_0);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_COEFF_1);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_COEFF_2);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_COEFF_3);
	rkisp1_iowrite32(params_vdev, 0x80, CIF_ISP_CT_COEFF_4);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_COEFF_5);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_COEFF_6);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_COEFF_7);
	rkisp1_iowrite32(params_vdev, 0x80, CIF_ISP_CT_COEFF_8);

	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_OFFSET_R);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_OFFSET_G);
	rkisp1_iowrite32(params_vdev, 0, CIF_ISP_CT_OFFSET_B);
}

/* ISP White Balance Mode */
static void isp_awb_meas_config_v10(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_awb_meas_config *arg)
{
	u32 reg_val = 0;
	/* based on the mode,configure the awb module */
	if (arg->awb_mode == CIFISP_AWB_MODE_YCBCR) {
		/* Reference Cb and Cr */
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AWB_REF_CR_SET(arg->awb_ref_cr) |
				 arg->awb_ref_cb, CIF_ISP_AWB_REF_V10);
		/* Yc Threshold */
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AWB_MAX_Y_SET(arg->max_y) |
				 CIF_ISP_AWB_MIN_Y_SET(arg->min_y) |
				 CIF_ISP_AWB_MAX_CS_SET(arg->max_csum) |
				 arg->min_c, CIF_ISP_AWB_THRESH_V10);
	}

	reg_val = rkisp1_ioread32(params_vdev, CIF_ISP_AWB_PROP_V10);
	if (arg->enable_ymax_cmp)
		reg_val |= CIF_ISP_AWB_YMAX_CMP_EN;
	else
		reg_val &= ~CIF_ISP_AWB_YMAX_CMP_EN;
	rkisp1_iowrite32(params_vdev, reg_val, CIF_ISP_AWB_PROP_V10);

	/* window offset */
	rkisp1_iowrite32(params_vdev,
			 arg->awb_wnd.v_offs, CIF_ISP_AWB_WND_V_OFFS_V10);
	rkisp1_iowrite32(params_vdev,
			 arg->awb_wnd.h_offs, CIF_ISP_AWB_WND_H_OFFS_V10);
	/* AWB window size */
	rkisp1_iowrite32(params_vdev,
			 arg->awb_wnd.v_size, CIF_ISP_AWB_WND_V_SIZE_V10);
	rkisp1_iowrite32(params_vdev,
			 arg->awb_wnd.h_size, CIF_ISP_AWB_WND_H_SIZE_V10);
	/* Number of frames */
	rkisp1_iowrite32(params_vdev,
			 arg->frames, CIF_ISP_AWB_FRAMES_V10);
}

static void isp_awb_meas_config_v12(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_awb_meas_config *arg)
{
	u32 reg_val = 0;
	/* based on the mode,configure the awb module */
	if (arg->awb_mode == CIFISP_AWB_MODE_YCBCR) {
		/* Reference Cb and Cr */
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AWB_REF_CR_SET(arg->awb_ref_cr) |
				 arg->awb_ref_cb, CIF_ISP_AWB_REF_V12);
		/* Yc Threshold */
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AWB_MAX_Y_SET(arg->max_y) |
				 CIF_ISP_AWB_MIN_Y_SET(arg->min_y) |
				 CIF_ISP_AWB_MAX_CS_SET(arg->max_csum) |
				 arg->min_c, CIF_ISP_AWB_THRESH_V12);
	}

	reg_val = rkisp1_ioread32(params_vdev, CIF_ISP_AWB_PROP_V12);
	if (arg->enable_ymax_cmp)
		reg_val |= CIF_ISP_AWB_YMAX_CMP_EN;
	else
		reg_val &= ~CIF_ISP_AWB_YMAX_CMP_EN;
	reg_val &= ~CIF_ISP_AWB_SET_FRAMES_MASK_V12;
	reg_val |= CIF_ISP_AWB_SET_FRAMES_V12(arg->frames);
	rkisp1_iowrite32(params_vdev, reg_val, CIF_ISP_AWB_PROP_V12);

	/* window offset */
	rkisp1_iowrite32(params_vdev,
			 arg->awb_wnd.v_offs << 16 |
			 arg->awb_wnd.h_offs,
			 CIF_ISP_AWB_OFFS_V12);
	/* AWB window size */
	rkisp1_iowrite32(params_vdev,
			 arg->awb_wnd.v_size << 16 |
			 arg->awb_wnd.h_size,
			 CIF_ISP_AWB_SIZE_V12);
}

static void isp_awb_meas_enable_v10(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_awb_meas_config *arg, bool en)
{
	u32 reg_val = rkisp1_ioread32(params_vdev, CIF_ISP_AWB_PROP_V10);

	/* switch off */
	reg_val &= CIF_ISP_AWB_MODE_MASK_NONE;

	if (en) {
		if (arg->awb_mode == CIFISP_AWB_MODE_RGB)
			reg_val |= CIF_ISP_AWB_MODE_RGB_EN;
		else
			reg_val |= CIF_ISP_AWB_MODE_YCBCR_EN;

		rkisp1_iowrite32(params_vdev, reg_val, CIF_ISP_AWB_PROP_V10);

		/* Measurements require AWB block be active. */
		/* TODO: need to enable here ? awb_gain_enable has done this */
		isp_param_set_bits(params_vdev, CIF_ISP_CTRL,
				   CIF_ISP_CTRL_ISP_AWB_ENA);
	} else {
		rkisp1_iowrite32(params_vdev,
				 reg_val, CIF_ISP_AWB_PROP_V10);
		isp_param_clear_bits(params_vdev, CIF_ISP_CTRL,
				     CIF_ISP_CTRL_ISP_AWB_ENA);
	}
}

static void isp_awb_meas_enable_v12(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_awb_meas_config *arg, bool en)
{
	u32 reg_val = rkisp1_ioread32(params_vdev, CIF_ISP_AWB_PROP_V12);

	/* switch off */
	reg_val &= CIF_ISP_AWB_MODE_MASK_NONE;

	if (en) {
		if (arg->awb_mode == CIFISP_AWB_MODE_RGB)
			reg_val |= CIF_ISP_AWB_MODE_RGB_EN;
		else
			reg_val |= CIF_ISP_AWB_MODE_YCBCR_EN;

		rkisp1_iowrite32(params_vdev, reg_val, CIF_ISP_AWB_PROP_V12);

		/* Measurements require AWB block be active. */
		/* TODO: need to enable here ? awb_gain_enable has done this */
		isp_param_set_bits(params_vdev, CIF_ISP_CTRL,
				   CIF_ISP_CTRL_ISP_AWB_ENA);
	} else {
		rkisp1_iowrite32(params_vdev,
				 reg_val, CIF_ISP_AWB_PROP_V12);
		isp_param_clear_bits(params_vdev, CIF_ISP_CTRL,
				     CIF_ISP_CTRL_ISP_AWB_ENA);
	}
}

static void isp_awb_gain_config_v10(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_awb_gain_config *arg)
{
	rkisp1_iowrite32(params_vdev,
			 CIF_ISP_AWB_GAIN_R_SET(arg->gain_green_r) |
			 arg->gain_green_b, CIF_ISP_AWB_GAIN_G_V10);

	rkisp1_iowrite32(params_vdev, CIF_ISP_AWB_GAIN_R_SET(arg->gain_red) |
			 arg->gain_blue, CIF_ISP_AWB_GAIN_RB_V10);
}

static void isp_awb_gain_config_v12(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_awb_gain_config *arg)
{
	rkisp1_iowrite32(params_vdev,
			 CIF_ISP_AWB_GAIN_R_SET(arg->gain_green_r) |
			 arg->gain_green_b, CIF_ISP_AWB_GAIN_G_V12);

	rkisp1_iowrite32(params_vdev, CIF_ISP_AWB_GAIN_R_SET(arg->gain_red) |
			 arg->gain_blue, CIF_ISP_AWB_GAIN_RB_V12);
}

static void isp_aec_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_aec_config *arg)
{
	unsigned int block_hsize, block_vsize;
	u32 exp_ctrl;

	/* avoid to override the old enable value */
	exp_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_EXP_CTRL);
	exp_ctrl &= CIF_ISP_EXP_ENA;
	if (arg->autostop)
		exp_ctrl |= CIF_ISP_EXP_CTRL_AUTOSTOP;
	if (arg->mode == CIFISP_EXP_MEASURING_MODE_1)
		exp_ctrl |= CIF_ISP_EXP_CTRL_MEASMODE_1;
	rkisp1_iowrite32(params_vdev, exp_ctrl, CIF_ISP_EXP_CTRL);

	rkisp1_iowrite32(params_vdev,
			 arg->meas_window.h_offs, CIF_ISP_EXP_H_OFFSET_V10);
	rkisp1_iowrite32(params_vdev,
			 arg->meas_window.v_offs, CIF_ISP_EXP_V_OFFSET_V10);

	block_hsize = arg->meas_window.h_size / CIF_ISP_EXP_COLUMN_NUM_V10 - 1;
	block_vsize = arg->meas_window.v_size / CIF_ISP_EXP_ROW_NUM_V10 - 1;

	rkisp1_iowrite32(params_vdev, CIF_ISP_EXP_H_SIZE_SET_V10(block_hsize),
			 CIF_ISP_EXP_H_SIZE_V10);
	rkisp1_iowrite32(params_vdev, CIF_ISP_EXP_V_SIZE_SET_V10(block_vsize),
			 CIF_ISP_EXP_V_SIZE_V10);
}

static void isp_aec_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_aec_config *arg)
{
	u32 exp_ctrl;
	u32 block_hsize, block_vsize;
	u32 wnd_num_idx = 1;
	const u32 ae_wnd_num[] = {
		5, 9, 15, 15
	};

	/* avoid to override the old enable value */
	exp_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_EXP_CTRL);
	exp_ctrl &= CIF_ISP_EXP_ENA;
	if (arg->autostop)
		exp_ctrl |= CIF_ISP_EXP_CTRL_AUTOSTOP;
	if (arg->mode == CIFISP_EXP_MEASURING_MODE_1)
		exp_ctrl |= CIF_ISP_EXP_CTRL_MEASMODE_1;
	exp_ctrl |= CIF_ISP_EXP_CTRL_WNDNUM_SET_V12(wnd_num_idx);
	rkisp1_iowrite32(params_vdev, exp_ctrl, CIF_ISP_EXP_CTRL);

	rkisp1_iowrite32(params_vdev,
			 CIF_ISP_EXP_V_OFFSET_SET_V12(arg->meas_window.v_offs) |
			 CIF_ISP_EXP_H_OFFSET_SET_V12(arg->meas_window.h_offs),
			 CIF_ISP_EXP_OFFS_V12);

	block_hsize = arg->meas_window.h_size / ae_wnd_num[wnd_num_idx] - 1;
	block_vsize = arg->meas_window.v_size / ae_wnd_num[wnd_num_idx] - 1;

	rkisp1_iowrite32(params_vdev,
			 CIF_ISP_EXP_V_SIZE_SET_V12(block_vsize) |
			 CIF_ISP_EXP_H_SIZE_SET_V12(block_hsize),
			 CIF_ISP_EXP_SIZE_V12);
}

static void isp_cproc_config(struct rkisp_isp_params_vdev *params_vdev,
			     const struct cifisp_cproc_config *arg)
{
	u32 quantization = params_vdev->quantization;

	rkisp1_iowrite32(params_vdev, arg->contrast, CIF_C_PROC_CONTRAST);
	rkisp1_iowrite32(params_vdev, arg->hue, CIF_C_PROC_HUE);
	rkisp1_iowrite32(params_vdev, arg->sat, CIF_C_PROC_SATURATION);
	rkisp1_iowrite32(params_vdev, arg->brightness, CIF_C_PROC_BRIGHTNESS);

	if (quantization != V4L2_QUANTIZATION_FULL_RANGE) {
		isp_param_clear_bits(params_vdev, CIF_C_PROC_CTRL,
				     CIF_C_PROC_YOUT_FULL |
				     CIF_C_PROC_YIN_FULL |
				     CIF_C_PROC_COUT_FULL);
	} else {
		isp_param_set_bits(params_vdev, CIF_C_PROC_CTRL,
				   CIF_C_PROC_YOUT_FULL |
				   CIF_C_PROC_YIN_FULL |
				   CIF_C_PROC_COUT_FULL);
	}
}

static void isp_hst_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_hst_config *arg)
{
	unsigned int block_hsize, block_vsize;
	const u32 hist_weight_regs[] = {
		CIF_ISP_HIST_WEIGHT_00TO30_V10, CIF_ISP_HIST_WEIGHT_40TO21_V10,
		CIF_ISP_HIST_WEIGHT_31TO12_V10, CIF_ISP_HIST_WEIGHT_22TO03_V10,
		CIF_ISP_HIST_WEIGHT_13TO43_V10, CIF_ISP_HIST_WEIGHT_04TO34_V10,
		CIF_ISP_HIST_WEIGHT_44_V10,
	};
	int i;
	const u8 *weight;
	u32 hist_prop;

	/* avoid to override the old enable value */
	hist_prop = rkisp1_ioread32(params_vdev, CIF_ISP_HIST_PROP_V10);
	hist_prop &= CIF_ISP_HIST_PROP_MODE_MASK_V10;
	hist_prop |= CIF_ISP_HIST_PREDIV_SET_V10(arg->histogram_predivider);
	rkisp1_iowrite32(params_vdev, hist_prop, CIF_ISP_HIST_PROP_V10);
	rkisp1_iowrite32(params_vdev,
			arg->meas_window.h_offs,
			CIF_ISP_HIST_H_OFFS_V10);
	rkisp1_iowrite32(params_vdev,
			arg->meas_window.v_offs,
			CIF_ISP_HIST_V_OFFS_V10);

	block_hsize = arg->meas_window.h_size / CIF_ISP_HIST_COLUMN_NUM_V10 - 1;
	block_vsize = arg->meas_window.v_size / CIF_ISP_HIST_ROW_NUM_V10 - 1;

	rkisp1_iowrite32(params_vdev, block_hsize, CIF_ISP_HIST_H_SIZE_V10);
	rkisp1_iowrite32(params_vdev, block_vsize, CIF_ISP_HIST_V_SIZE_V10);

	weight = arg->hist_weight;
	for (i = 0; i < ARRAY_SIZE(hist_weight_regs); ++i, weight += 4)
		rkisp1_iowrite32(params_vdev, CIF_ISP_HIST_WEIGHT_SET_V10(
				 weight[0], weight[1], weight[2], weight[3]),
				 hist_weight_regs[i]);
}

static void isp_hst_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_hst_config *arg)
{
	u32 i, j;
	u32 value;
	u32 hist_ctrl;
	u32 block_hsize, block_vsize;
	u32 wnd_num_idx, hist_weight_num;
	u8 weight15x15[CIF_ISP_HIST_WEIGHT_REG_SIZE_V12];
	const u32 hist_wnd_num[] = {
		5, 9, 15, 15
	};

	/* now we just support 9x9 window */
	wnd_num_idx = 1;
	memset(weight15x15, 0x00, sizeof(weight15x15));
	/* avoid to override the old enable value */
	hist_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_HIST_CTRL_V12);
	hist_ctrl &= CIF_ISP_HIST_CTRL_MODE_MASK_V12 |
		     CIF_ISP_HIST_CTRL_EN_MASK_V12;
	hist_ctrl = hist_ctrl |
		    CIF_ISP_HIST_CTRL_INTRSEL_SET_V12(1) |
		    CIF_ISP_HIST_CTRL_DATASEL_SET_V12(0) |
		    CIF_ISP_HIST_CTRL_WATERLINE_SET_V12(0) |
		    CIF_ISP_HIST_CTRL_AUTOSTOP_SET_V12(0) |
		    CIF_ISP_HIST_CTRL_WNDNUM_SET_V12(1) |
		    CIF_ISP_HIST_CTRL_STEPSIZE_SET_V12(arg->histogram_predivider);
	rkisp1_iowrite32(params_vdev, hist_ctrl, CIF_ISP_HIST_CTRL_V12);

	rkisp1_iowrite32(params_vdev,
			 CIF_ISP_HIST_OFFS_SET_V12(arg->meas_window.h_offs,
						   arg->meas_window.v_offs),
			 CIF_ISP_HIST_OFFS_V12);

	block_hsize = arg->meas_window.h_size / hist_wnd_num[wnd_num_idx] - 1;
	block_vsize = arg->meas_window.v_size / hist_wnd_num[wnd_num_idx] - 1;
	rkisp1_iowrite32(params_vdev,
			 CIF_ISP_HIST_SIZE_SET_V12(block_hsize, block_vsize),
			 CIF_ISP_HIST_SIZE_V12);

	for (i = 0; i < hist_wnd_num[wnd_num_idx]; i++) {
		for (j = 0; j < hist_wnd_num[wnd_num_idx]; j++) {
			weight15x15[i * CIF_ISP_HIST_ROW_NUM_V12 + j] =
				arg->hist_weight[i * hist_wnd_num[wnd_num_idx] + j];
		}
	}

	hist_weight_num = CIF_ISP_HIST_WEIGHT_REG_SIZE_V12;
	for (i = 0; i < (hist_weight_num / 4); i++) {
		value = CIF_ISP_HIST_WEIGHT_SET_V12(
				 weight15x15[4 * i + 0],
				 weight15x15[4 * i + 1],
				 weight15x15[4 * i + 2],
				 weight15x15[4 * i + 3]);
		rkisp1_iowrite32(params_vdev, value,
				 CIF_ISP_HIST_WEIGHT_V12 + 4 * i);
	}
	value = CIF_ISP_HIST_WEIGHT_SET_V12(
				 weight15x15[4 * i + 0], 0, 0, 0);
	rkisp1_iowrite32(params_vdev, value,
				 CIF_ISP_HIST_WEIGHT_V12 + 4 * i);
}

static void isp_hst_enable_v10(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_hst_config *arg, bool en)
{
	if (en) {
		u32 hist_prop = rkisp1_ioread32(params_vdev, CIF_ISP_HIST_PROP_V10);

		hist_prop &= ~CIF_ISP_HIST_PROP_MODE_MASK_V10;
		hist_prop |= arg->mode;
		isp_param_set_bits(params_vdev, CIF_ISP_HIST_PROP_V10, hist_prop);
	} else {
		isp_param_clear_bits(params_vdev, CIF_ISP_HIST_PROP_V10,
				CIF_ISP_HIST_PROP_MODE_MASK_V10);
	}
}

static void isp_hst_enable_v12(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_hst_config *arg, bool en)
{
	if (en) {
		u32 hist_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_HIST_CTRL_V12);

		hist_ctrl &= ~CIF_ISP_HIST_CTRL_MODE_MASK_V12;
		hist_ctrl |= CIF_ISP_HIST_CTRL_MODE_SET_V12(arg->mode);
		hist_ctrl |= CIF_ISP_HIST_CTRL_EN_SET_V12(1);
		isp_param_set_bits(params_vdev, CIF_ISP_HIST_CTRL_V12, hist_ctrl);
	} else {
		isp_param_clear_bits(params_vdev, CIF_ISP_HIST_CTRL_V12,
				CIF_ISP_HIST_CTRL_MODE_MASK_V12 |
				CIF_ISP_HIST_CTRL_EN_MASK_V12);
	}
}

static void isp_afm_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_afc_config *arg)
{
	int i;
	size_t num_of_win = min_t(size_t, ARRAY_SIZE(arg->afm_win),
				  arg->num_afm_win);
	u32 afm_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_AFM_CTRL);

	/* Switch off to configure. */
	isp_param_clear_bits(params_vdev, CIF_ISP_AFM_CTRL, CIF_ISP_AFM_ENA);

	for (i = 0; i < num_of_win; i++) {
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AFM_WINDOW_X(arg->afm_win[i].h_offs) |
				 CIF_ISP_AFM_WINDOW_Y(arg->afm_win[i].v_offs),
				 CIF_ISP_AFM_LT_A + i * 8);
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AFM_WINDOW_X(arg->afm_win[i].h_size +
						      arg->afm_win[i].h_offs) |
				 CIF_ISP_AFM_WINDOW_Y(arg->afm_win[i].v_size +
						      arg->afm_win[i].v_offs),
				 CIF_ISP_AFM_RB_A + i * 8);
	}
	rkisp1_iowrite32(params_vdev, arg->thres, CIF_ISP_AFM_THRES);
	rkisp1_iowrite32(params_vdev, arg->var_shift, CIF_ISP_AFM_VAR_SHIFT);
	/* restore afm status */
	rkisp1_iowrite32(params_vdev, afm_ctrl, CIF_ISP_AFM_CTRL);
}

static void isp_afm_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_afc_config *arg)
{
	unsigned int i;
	u32 lum_var_shift, afm_var_shift;
	size_t num_of_win = min_t(size_t, ARRAY_SIZE(arg->afm_win),
				  arg->num_afm_win);
	u32 afm_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_AFM_CTRL);

	/* Switch off to configure. */
	isp_param_clear_bits(params_vdev, CIF_ISP_AFM_CTRL, CIF_ISP_AFM_ENA);

	for (i = 0; i < num_of_win; i++) {
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AFM_WINDOW_X(arg->afm_win[i].h_offs) |
				 CIF_ISP_AFM_WINDOW_Y(arg->afm_win[i].v_offs),
				 CIF_ISP_AFM_LT_A + i * 8);
		rkisp1_iowrite32(params_vdev,
				 CIF_ISP_AFM_WINDOW_X(arg->afm_win[i].h_size +
						      arg->afm_win[i].h_offs) |
				 CIF_ISP_AFM_WINDOW_Y(arg->afm_win[i].v_size +
						      arg->afm_win[i].v_offs),
				 CIF_ISP_AFM_RB_A + i * 8);
	}
	rkisp1_iowrite32(params_vdev, arg->thres, CIF_ISP_AFM_THRES);

	lum_var_shift = CIF_ISP_AFM_GET_LUM_SHIFT_a_V12(arg->var_shift);
	afm_var_shift = CIF_ISP_AFM_GET_AFM_SHIFT_a_V12(arg->var_shift);
	rkisp1_iowrite32(params_vdev,
		CIF_ISP_AFM_SET_SHIFT_a_V12(lum_var_shift, afm_var_shift) |
		CIF_ISP_AFM_SET_SHIFT_b_V12(lum_var_shift, afm_var_shift) |
		CIF_ISP_AFM_SET_SHIFT_c_V12(lum_var_shift, afm_var_shift),
		CIF_ISP_AFM_VAR_SHIFT);

	/* restore afm status */
	rkisp1_iowrite32(params_vdev, afm_ctrl, CIF_ISP_AFM_CTRL);
}

static void isp_ie_config(struct rkisp_isp_params_vdev *params_vdev,
			  const struct cifisp_ie_config *arg)
{
	u32 eff_ctrl;

	eff_ctrl = rkisp1_ioread32(params_vdev, CIF_IMG_EFF_CTRL);
	eff_ctrl &= ~CIF_IMG_EFF_CTRL_MODE_MASK;

	if (params_vdev->quantization == V4L2_QUANTIZATION_FULL_RANGE)
		eff_ctrl |= CIF_IMG_EFF_CTRL_YCBCR_FULL;

	switch (arg->effect) {
	case V4L2_COLORFX_SEPIA:
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_SEPIA;
		break;
	case V4L2_COLORFX_SET_CBCR:
		rkisp1_iowrite32(params_vdev, arg->eff_tint, CIF_IMG_EFF_TINT);
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_SEPIA;
		break;
		/*
		 * Color selection is similar to water color(AQUA):
		 * grayscale + selected color w threshold
		 */
	case V4L2_COLORFX_AQUA:
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_COLOR_SEL;
		rkisp1_iowrite32(params_vdev, arg->color_sel,
				 CIF_IMG_EFF_COLOR_SEL);
		break;
	case V4L2_COLORFX_EMBOSS:
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_EMBOSS;
		rkisp1_iowrite32(params_vdev, arg->eff_mat_1,
				 CIF_IMG_EFF_MAT_1);
		rkisp1_iowrite32(params_vdev, arg->eff_mat_2,
				 CIF_IMG_EFF_MAT_2);
		rkisp1_iowrite32(params_vdev, arg->eff_mat_3,
				 CIF_IMG_EFF_MAT_3);
		break;
	case V4L2_COLORFX_SKETCH:
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_SKETCH;
		rkisp1_iowrite32(params_vdev, arg->eff_mat_3,
				 CIF_IMG_EFF_MAT_3);
		rkisp1_iowrite32(params_vdev, arg->eff_mat_4,
				 CIF_IMG_EFF_MAT_4);
		rkisp1_iowrite32(params_vdev, arg->eff_mat_5,
				 CIF_IMG_EFF_MAT_5);
		break;
	case V4L2_COLORFX_BW:
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_BLACKWHITE;
		break;
	case V4L2_COLORFX_NEGATIVE:
		eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_NEGATIVE;
		break;
	default:
		break;
	}

	rkisp1_iowrite32(params_vdev, eff_ctrl, CIF_IMG_EFF_CTRL);
}

static void isp_ie_enable(struct rkisp_isp_params_vdev *params_vdev, bool en)
{
	if (en) {
		isp_param_set_bits(params_vdev, CIF_ICCL, CIF_ICCL_IE_CLK);
		isp_param_set_bits(params_vdev, CIF_IMG_EFF_CTRL,
				   CIF_IMG_EFF_CTRL_ENABLE);
		isp_param_set_bits(params_vdev, CIF_IMG_EFF_CTRL,
				   CIF_IMG_EFF_CTRL_CFG_UPD);
	} else {
		isp_param_clear_bits(params_vdev, CIF_IMG_EFF_CTRL,
				     CIF_IMG_EFF_CTRL_ENABLE);
		isp_param_clear_bits(params_vdev, CIF_ICCL, CIF_ICCL_IE_CLK);
	}
}

static void isp_csm_config(struct rkisp_isp_params_vdev *params_vdev,
			   bool full_range)
{
	const u16 full_range_coeff[] = {
		0x0026, 0x004b, 0x000f,
		0x01ea, 0x01d6, 0x0040,
		0x0040, 0x01ca, 0x01f6
	};
	const u16 limited_range_coeff[] = {
		0x0021, 0x0040, 0x000d,
		0x01ed, 0x01db, 0x0038,
		0x0038, 0x01d1, 0x01f7,
	};
	unsigned int i;

	if (full_range) {
		for (i = 0; i < ARRAY_SIZE(full_range_coeff); i++)
			rkisp1_iowrite32(params_vdev, full_range_coeff[i],
					 CIF_ISP_CC_COEFF_0 + i * 4);

		isp_param_set_bits(params_vdev, CIF_ISP_CTRL,
				   CIF_ISP_CTRL_ISP_CSM_Y_FULL_ENA |
				   CIF_ISP_CTRL_ISP_CSM_C_FULL_ENA);
	} else {
		for (i = 0; i < ARRAY_SIZE(limited_range_coeff); i++)
			rkisp1_iowrite32(params_vdev, limited_range_coeff[i],
					 CIF_ISP_CC_COEFF_0 + i * 4);

		isp_param_clear_bits(params_vdev, CIF_ISP_CTRL,
				     CIF_ISP_CTRL_ISP_CSM_Y_FULL_ENA |
				     CIF_ISP_CTRL_ISP_CSM_C_FULL_ENA);
	}
}

/* ISP De-noise Pre-Filter(DPF) function */
static void isp_dpf_config(struct rkisp_isp_params_vdev *params_vdev,
			   const struct cifisp_dpf_config *arg)
{
	unsigned int isp_dpf_mode;
	unsigned int spatial_coeff;
	unsigned int i;

	switch (arg->gain.mode) {
	case CIFISP_DPF_GAIN_USAGE_NF_GAINS:
		isp_dpf_mode = CIF_ISP_DPF_MODE_USE_NF_GAIN |
				CIF_ISP_DPF_MODE_AWB_GAIN_COMP;
		break;
	case CIFISP_DPF_GAIN_USAGE_LSC_GAINS:
		isp_dpf_mode = CIF_ISP_DPF_MODE_LSC_GAIN_COMP;
		break;
	case CIFISP_DPF_GAIN_USAGE_NF_LSC_GAINS:
		isp_dpf_mode = CIF_ISP_DPF_MODE_USE_NF_GAIN |
				CIF_ISP_DPF_MODE_AWB_GAIN_COMP |
				CIF_ISP_DPF_MODE_LSC_GAIN_COMP;
		break;
	case CIFISP_DPF_GAIN_USAGE_AWB_GAINS:
		isp_dpf_mode = CIF_ISP_DPF_MODE_AWB_GAIN_COMP;
		break;
	case CIFISP_DPF_GAIN_USAGE_AWB_LSC_GAINS:
		isp_dpf_mode = CIF_ISP_DPF_MODE_LSC_GAIN_COMP |
				CIF_ISP_DPF_MODE_AWB_GAIN_COMP;
		break;
	case CIFISP_DPF_GAIN_USAGE_DISABLED:
	default:
		isp_dpf_mode = 0;
		break;
	}

	if (arg->nll.scale_mode == CIFISP_NLL_SCALE_LOGARITHMIC)
		isp_dpf_mode |= CIF_ISP_DPF_MODE_NLL_SEGMENTATION;
	if (arg->rb_flt.fltsize == CIFISP_DPF_RB_FILTERSIZE_9x9)
		isp_dpf_mode |= CIF_ISP_DPF_MODE_RB_FLTSIZE_9x9;
	if (!arg->rb_flt.r_enable)
		isp_dpf_mode |= CIF_ISP_DPF_MODE_R_FLT_DIS;
	if (!arg->rb_flt.b_enable)
		isp_dpf_mode |= CIF_ISP_DPF_MODE_B_FLT_DIS;
	if (!arg->g_flt.gb_enable)
		isp_dpf_mode |= CIF_ISP_DPF_MODE_GB_FLT_DIS;
	if (!arg->g_flt.gr_enable)
		isp_dpf_mode |= CIF_ISP_DPF_MODE_GR_FLT_DIS;

	isp_param_set_bits(params_vdev, CIF_ISP_DPF_MODE, isp_dpf_mode);
	rkisp1_iowrite32(params_vdev, arg->gain.nf_b_gain,
			 CIF_ISP_DPF_NF_GAIN_B);
	rkisp1_iowrite32(params_vdev, arg->gain.nf_r_gain,
			 CIF_ISP_DPF_NF_GAIN_R);
	rkisp1_iowrite32(params_vdev, arg->gain.nf_gb_gain,
			 CIF_ISP_DPF_NF_GAIN_GB);
	rkisp1_iowrite32(params_vdev, arg->gain.nf_gr_gain,
			 CIF_ISP_DPF_NF_GAIN_GR);

	for (i = 0; i < CIFISP_DPF_MAX_NLF_COEFFS; i++) {
		rkisp1_iowrite32(params_vdev, arg->nll.coeff[i],
				 CIF_ISP_DPF_NULL_COEFF_0 + i * 4);
	}

	spatial_coeff = arg->g_flt.spatial_coeff[0] |
			(arg->g_flt.spatial_coeff[1] << 8) |
			(arg->g_flt.spatial_coeff[2] << 16) |
			(arg->g_flt.spatial_coeff[3] << 24);
	rkisp1_iowrite32(params_vdev, spatial_coeff,
			 CIF_ISP_DPF_S_WEIGHT_G_1_4);

	spatial_coeff = arg->g_flt.spatial_coeff[4] |
			(arg->g_flt.spatial_coeff[5] << 8);
	rkisp1_iowrite32(params_vdev, spatial_coeff,
			 CIF_ISP_DPF_S_WEIGHT_G_5_6);

	spatial_coeff = arg->rb_flt.spatial_coeff[0] |
			(arg->rb_flt.spatial_coeff[1] << 8) |
			(arg->rb_flt.spatial_coeff[2] << 16) |
			(arg->rb_flt.spatial_coeff[3] << 24);
	rkisp1_iowrite32(params_vdev, spatial_coeff,
			 CIF_ISP_DPF_S_WEIGHT_RB_1_4);

	spatial_coeff = arg->rb_flt.spatial_coeff[4] |
			(arg->rb_flt.spatial_coeff[5] << 8);
	rkisp1_iowrite32(params_vdev, spatial_coeff,
			CIF_ISP_DPF_S_WEIGHT_RB_5_6);
}

static void isp_dpf_strength_config(struct rkisp_isp_params_vdev *params_vdev,
				    const struct cifisp_dpf_strength_config *arg)
{
	rkisp1_iowrite32(params_vdev, arg->b, CIF_ISP_DPF_STRENGTH_B);
	rkisp1_iowrite32(params_vdev, arg->g, CIF_ISP_DPF_STRENGTH_G);
	rkisp1_iowrite32(params_vdev, arg->r, CIF_ISP_DPF_STRENGTH_R);
}

static void isp_dummy_enable(struct rkisp_isp_params_vdev *params_vdev,
			     bool en)
{
}

static void isp_wdr_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_wdr_config *arg)
{
}

static void isp_wdr_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			       const struct cifisp_wdr_config *arg)
{
	int i;

	for (i = 0; i < CIFISP_WDR_SIZE; i++) {
		if (i <= 39)
			rkisp1_iowrite32(params_vdev, arg->c_wdr[i],
					 CIF_ISP_WDR_CTRL + i * 4);
		else
			rkisp1_iowrite32(params_vdev, arg->c_wdr[i],
					 CIF_ISP_RKWDR_CTRL0 + (i - 40) * 4);
	}
}

static void isp_wdr_enable_v12(struct rkisp_isp_params_vdev *params_vdev,
			       bool en)
{
	if (en)
		rkisp1_iowrite32(params_vdev, 0x030cf1,
				 CIF_ISP_RKWDR_CTRL0);
	else
		rkisp1_iowrite32(params_vdev, 0x030cf0,
				 CIF_ISP_RKWDR_CTRL0);
}

static void
isp_demosaiclp_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			  const struct cifisp_demosaiclp_config *arg)
{
}

static void
isp_demosaiclp_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			  const struct cifisp_demosaiclp_config *arg)
{
	u32 val;
	u32 level_sel;

	val = CIF_ISP_PACK_4BYTE(arg->lu_divided[0],
				 arg->lu_divided[1],
				 arg->lu_divided[2],
				 arg->lu_divided[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_LU_DIVID);

	val = CIF_ISP_PACK_4BYTE(arg->thgrad_divided[0],
				 arg->thgrad_divided[1],
				 arg->thgrad_divided[2],
				 arg->thgrad_divided[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_THGRAD_DIVID0123);
	rkisp1_iowrite32(params_vdev,
			 arg->thgrad_divided[4],
			 CIF_ISP_FILT_THGRAD_DIVID4);

	val = CIF_ISP_PACK_4BYTE(arg->thdiff_divided[0],
				 arg->thdiff_divided[1],
				 arg->thdiff_divided[2],
				 arg->thdiff_divided[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_THDIFF_DIVID0123);
	rkisp1_iowrite32(params_vdev,
			 arg->thdiff_divided[4],
			 CIF_ISP_FILT_THDIFF_DIVID4);

	val = CIF_ISP_PACK_4BYTE(arg->thcsc_divided[0],
				 arg->thcsc_divided[1],
				 arg->thcsc_divided[2],
				 arg->thcsc_divided[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_THCSC_DIVID0123);
	rkisp1_iowrite32(params_vdev, arg->thcsc_divided[4],
			 CIF_ISP_FILT_THCSC_DIVID4);

	val = CIF_ISP_PACK_2SHORT(arg->thvar_divided[0],
				  arg->thvar_divided[1]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_THVAR_DIVID01);

	val = CIF_ISP_PACK_2SHORT(arg->thvar_divided[2],
				  arg->thvar_divided[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_THVAR_DIVID23);
	rkisp1_iowrite32(params_vdev, arg->thvar_divided[4],
			 CIF_ISP_FILT_THVAR_DIVID4);

	rkisp1_iowrite32(params_vdev, arg->th_grad,
			 CIF_ISP_FILT_TH_GRAD);
	rkisp1_iowrite32(params_vdev, arg->th_diff,
			 CIF_ISP_FILT_TH_DIFF);
	rkisp1_iowrite32(params_vdev, arg->th_csc,
			 CIF_ISP_FILT_TH_CSC);
	rkisp1_iowrite32(params_vdev, arg->th_var,
			 CIF_ISP_FILT_TH_VAR);

	val = CIF_ISP_PACK_4BYTE(arg->thvar_r_fct,
				 arg->thdiff_r_fct,
				 arg->thgrad_r_fct,
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_R_FCT);

	val = CIF_ISP_PACK_4BYTE(arg->thgrad_b_fct,
				 arg->thdiff_b_fct,
				 arg->thvar_b_fct,
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_ISP_FILT_B_FCT);

	isp_param_set_bits(params_vdev,
			   CIF_ISP_FILT_MODE,
			   arg->rb_filter_en << 3 |
			   arg->hp_filter_en << 2);

	level_sel = rkisp1_ioread32(params_vdev, CIF_ISP_FILT_LELEL_SEL);
	level_sel &= CIF_ISP_FLT_LEVEL_OLD_LP;
	level_sel |= arg->th_var_en << 20 |
		     arg->th_csc_en << 19 |
		     arg->th_diff_en << 18 |
		     arg->th_grad_en << 17 |
		     arg->similarity_th << 12 |
		     arg->flat_level_sel << 8 |
		     arg->pattern_level_sel << 4 |
		     arg->edge_level_sel;

	rkisp1_iowrite32(params_vdev, level_sel,
			 CIF_ISP_FILT_LELEL_SEL);
}

static void
isp_demosaiclp_enable_v12(struct rkisp_isp_params_vdev *params_vdev,
			  bool en)
{
	if (en)
		isp_param_clear_bits(params_vdev,
				     CIF_ISP_FILT_LELEL_SEL,
				     CIF_ISP_FLT_LEVEL_OLD_LP);
	else
		isp_param_set_bits(params_vdev,
				   CIF_ISP_FILT_LELEL_SEL,
				   CIF_ISP_FLT_LEVEL_OLD_LP);
}

static void
isp_rkiesharp_config_v10(struct rkisp_isp_params_vdev *params_vdev,
			 const struct cifisp_rkiesharp_config *arg)
{
}

static void
isp_rkiesharp_config_v12(struct rkisp_isp_params_vdev *params_vdev,
			 const struct cifisp_rkiesharp_config *arg)
{
	u32 i;
	u32 val;
	u32 eff_ctrl;
	u32 minmax[5];

	val = CIF_ISP_PACK_4BYTE(arg->yavg_thr[0],
				 arg->yavg_thr[1],
				 arg->yavg_thr[2],
				 arg->yavg_thr[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_YAVG_THR);

	val = CIF_ISP_PACK_4BYTE(arg->delta1[0],
				 arg->delta2[0],
				 arg->delta1[1],
				 arg->delta2[1]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_DELTA_P0_P1);

	val = CIF_ISP_PACK_4BYTE(arg->delta1[2],
				 arg->delta2[2],
				 arg->delta1[3],
				 arg->delta2[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_DELTA_P2_P3);

	val = CIF_ISP_PACK_4BYTE(arg->delta1[4],
				 arg->delta2[4],
				 0,
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_DELTA_P4);

	for (i = 0; i < 5; i++)
		minmax[i] = arg->minnumber[i] << 4 | arg->maxnumber[i];
	val = CIF_ISP_PACK_4BYTE(minmax[0],
				 minmax[1],
				 minmax[2],
				 minmax[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_NPIXEL_P0_P1_P2_P3);
	rkisp1_iowrite32(params_vdev, minmax[4],
			 CIF_RKSHARP_NPIXEL_P4);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_flat_coe[0],
				 arg->gauss_flat_coe[1],
				 arg->gauss_flat_coe[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_FLAT_COE1);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_flat_coe[3],
				 arg->gauss_flat_coe[4],
				 arg->gauss_flat_coe[5],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_FLAT_COE2);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_flat_coe[6],
				 arg->gauss_flat_coe[7],
				 arg->gauss_flat_coe[8],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_FLAT_COE3);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_noise_coe[0],
				 arg->gauss_noise_coe[1],
				 arg->gauss_noise_coe[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_NOISE_COE1);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_noise_coe[3],
				 arg->gauss_noise_coe[4],
				 arg->gauss_noise_coe[5],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_NOISE_COE2);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_noise_coe[6],
				 arg->gauss_noise_coe[7],
				 arg->gauss_noise_coe[8],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_NOISE_COE3);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_other_coe[0],
				 arg->gauss_other_coe[1],
				 arg->gauss_other_coe[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_OTHER_COE1);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_other_coe[3],
				 arg->gauss_other_coe[4],
				 arg->gauss_other_coe[5],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_OTHER_COE2);

	val = CIF_ISP_PACK_4BYTE(arg->gauss_other_coe[6],
				 arg->gauss_other_coe[7],
				 arg->gauss_other_coe[8],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GAUSS_OTHER_COE3);

	val = CIF_ISP_PACK_4BYTE(arg->line1_filter_coe[0],
				 arg->line1_filter_coe[1],
				 arg->line1_filter_coe[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE1_FILTER_COE1);

	val = CIF_ISP_PACK_4BYTE(arg->line1_filter_coe[3],
				 arg->line1_filter_coe[4],
				 arg->line1_filter_coe[5],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE1_FILTER_COE2);

	val = CIF_ISP_PACK_4BYTE(arg->line2_filter_coe[0],
				 arg->line2_filter_coe[1],
				 arg->line2_filter_coe[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE2_FILTER_COE1);

	val = CIF_ISP_PACK_4BYTE(arg->line2_filter_coe[3],
				 arg->line2_filter_coe[4],
				 arg->line2_filter_coe[5],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE2_FILTER_COE2);

	val = CIF_ISP_PACK_4BYTE(arg->line2_filter_coe[6],
				 arg->line2_filter_coe[7],
				 arg->line2_filter_coe[8],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE2_FILTER_COE3);

	val = CIF_ISP_PACK_4BYTE(arg->line3_filter_coe[0],
				 arg->line3_filter_coe[1],
				 arg->line3_filter_coe[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE3_FILTER_COE1);

	val = CIF_ISP_PACK_4BYTE(arg->line3_filter_coe[3],
				 arg->line3_filter_coe[4],
				 arg->line3_filter_coe[5],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_LINE3_FILTER_COE2);

	val = CIF_ISP_PACK_2SHORT(arg->grad_seq[0],
				  arg->grad_seq[1]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GRAD_SEQ_P0_P1);

	val = CIF_ISP_PACK_2SHORT(arg->grad_seq[2],
				  arg->grad_seq[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_GRAD_SEQ_P2_P3);

	val = CIF_ISP_PACK_4BYTE(arg->sharp_factor[0],
				 arg->sharp_factor[1],
				 arg->sharp_factor[2],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_SHARP_FACTOR_P0_P1_P2);

	val = CIF_ISP_PACK_4BYTE(arg->sharp_factor[3],
				 arg->sharp_factor[4],
				 0,
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_SHARP_FACTOR_P3_P4);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_flat_coe[0],
				 arg->uv_gauss_flat_coe[1],
				 arg->uv_gauss_flat_coe[2],
				 arg->uv_gauss_flat_coe[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_FLAT_COE11_COE14);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_flat_coe[4],
				 arg->uv_gauss_flat_coe[5],
				 arg->uv_gauss_flat_coe[6],
				 arg->uv_gauss_flat_coe[7]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_FLAT_COE15_COE23);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_flat_coe[8],
				 arg->uv_gauss_flat_coe[9],
				 arg->uv_gauss_flat_coe[10],
				 arg->uv_gauss_flat_coe[11]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_FLAT_COE24_COE32);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_flat_coe[12],
				 arg->uv_gauss_flat_coe[13],
				 arg->uv_gauss_flat_coe[14],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_FLAT_COE33_COE35);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_noise_coe[0],
				 arg->uv_gauss_noise_coe[1],
				 arg->uv_gauss_noise_coe[2],
				 arg->uv_gauss_noise_coe[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_NOISE_COE11_COE14);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_noise_coe[4],
				 arg->uv_gauss_noise_coe[5],
				 arg->uv_gauss_noise_coe[6],
				 arg->uv_gauss_noise_coe[7]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_NOISE_COE15_COE23);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_noise_coe[8],
				 arg->uv_gauss_noise_coe[9],
				 arg->uv_gauss_noise_coe[10],
				 arg->uv_gauss_noise_coe[11]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_NOISE_COE24_COE32);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_noise_coe[12],
				 arg->uv_gauss_noise_coe[13],
				 arg->uv_gauss_noise_coe[14],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_NOISE_COE33_COE35);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_other_coe[0],
				 arg->uv_gauss_other_coe[1],
				 arg->uv_gauss_other_coe[2],
				 arg->uv_gauss_other_coe[3]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_OTHER_COE11_COE14);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_other_coe[4],
				 arg->uv_gauss_other_coe[5],
				 arg->uv_gauss_other_coe[6],
				 arg->uv_gauss_other_coe[7]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_OTHER_COE15_COE23);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_other_coe[8],
				 arg->uv_gauss_other_coe[9],
				 arg->uv_gauss_other_coe[10],
				 arg->uv_gauss_other_coe[11]);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_OTHER_COE24_COE32);

	val = CIF_ISP_PACK_4BYTE(arg->uv_gauss_other_coe[12],
				 arg->uv_gauss_other_coe[13],
				 arg->uv_gauss_other_coe[14],
				 0);
	rkisp1_iowrite32(params_vdev, val,
			 CIF_RKSHARP_UV_GAUSS_OTHER_COE33_COE35);

	rkisp1_iowrite32(params_vdev, arg->switch_avg,
			 CIF_RKSHARP_CTRL);

	rkisp1_iowrite32(params_vdev,
			 arg->coring_thr,
			 CIF_IMG_EFF_SHARPEN);

	val = rkisp1_ioread32(params_vdev, CIF_IMG_EFF_MAT_3) & 0x0F;
	val |= (arg->lap_mat_coe[0] & 0x0F) << 4 |
	       (arg->lap_mat_coe[1] & 0x0F) << 8 |
	       (arg->lap_mat_coe[2] & 0x0F) << 12;
	rkisp1_iowrite32(params_vdev, val, CIF_IMG_EFF_MAT_3);

	val = (arg->lap_mat_coe[3] & 0x0F) << 0 |
	       (arg->lap_mat_coe[4] & 0x0F) << 4 |
	       (arg->lap_mat_coe[5] & 0x0F) << 8 |
	       (arg->lap_mat_coe[6] & 0x0F) << 12;
	rkisp1_iowrite32(params_vdev, val, CIF_IMG_EFF_MAT_4);

	val = (arg->lap_mat_coe[7] & 0x0F) << 0 |
	       (arg->lap_mat_coe[8] & 0x0F) << 4;
	rkisp1_iowrite32(params_vdev, val, CIF_IMG_EFF_MAT_5);

	eff_ctrl = rkisp1_ioread32(params_vdev, CIF_IMG_EFF_CTRL);
	eff_ctrl &= ~CIF_IMG_EFF_CTRL_MODE_MASK;
	eff_ctrl |= CIF_IMG_EFF_CTRL_MODE_RKSHARPEN;

	if (arg->full_range)
		eff_ctrl |= CIF_IMG_EFF_CTRL_YCBCR_FULL;

	rkisp1_iowrite32(params_vdev, eff_ctrl, CIF_IMG_EFF_CTRL);
}

static struct rkisp_isp_params_v1x_ops rkisp1_v10_isp_params_ops = {
	.dpcc_config = isp_dpcc_config,
	.bls_config = isp_bls_config,
	.lsc_config = isp_lsc_config,
	.lsc_matrix_config = isp_lsc_matrix_config_v10,
	.flt_config = isp_flt_config,
	.bdm_config = isp_bdm_config,
	.sdg_config = isp_sdg_config,
	.goc_config = isp_goc_config_v10,
	.ctk_config = isp_ctk_config,
	.ctk_enable = isp_ctk_enable,
	.awb_meas_config = isp_awb_meas_config_v10,
	.awb_meas_enable = isp_awb_meas_enable_v10,
	.awb_gain_config = isp_awb_gain_config_v10,
	.aec_config = isp_aec_config_v10,
	.cproc_config = isp_cproc_config,
	.hst_config = isp_hst_config_v10,
	.hst_enable = isp_hst_enable_v10,
	.afm_config = isp_afm_config_v10,
	.ie_config = isp_ie_config,
	.ie_enable = isp_ie_enable,
	.csm_config = isp_csm_config,
	.dpf_config = isp_dpf_config,
	.dpf_strength_config = isp_dpf_strength_config,
	.wdr_config = isp_wdr_config_v10,
	.wdr_enable = isp_dummy_enable,
	.demosaiclp_config = isp_demosaiclp_config_v10,
	.demosaiclp_enable = isp_dummy_enable,
	.rkiesharp_config = isp_rkiesharp_config_v10,
	.rkiesharp_enable = isp_dummy_enable,
};

static struct rkisp_isp_params_v1x_ops rkisp1_v12_isp_params_ops = {
	.dpcc_config = isp_dpcc_config,
	.bls_config = isp_bls_config,
	.lsc_config = isp_lsc_config,
	.lsc_matrix_config = isp_lsc_matrix_config_v12,
	.flt_config = isp_flt_config,
	.bdm_config = isp_bdm_config,
	.sdg_config = isp_sdg_config,
	.goc_config = isp_goc_config_v12,
	.ctk_config = isp_ctk_config,
	.ctk_enable = isp_ctk_enable,
	.awb_meas_config = isp_awb_meas_config_v12,
	.awb_meas_enable = isp_awb_meas_enable_v12,
	.awb_gain_config = isp_awb_gain_config_v12,
	.aec_config = isp_aec_config_v12,
	.cproc_config = isp_cproc_config,
	.hst_config = isp_hst_config_v12,
	.hst_enable = isp_hst_enable_v12,
	.afm_config = isp_afm_config_v12,
	.ie_config = isp_ie_config,
	.ie_enable = isp_ie_enable,
	.csm_config = isp_csm_config,
	.dpf_config = isp_dpf_config,
	.dpf_strength_config = isp_dpf_strength_config,
	.wdr_config = isp_wdr_config_v12,
	.wdr_enable = isp_wdr_enable_v12,
	.demosaiclp_config = isp_demosaiclp_config_v12,
	.demosaiclp_enable = isp_demosaiclp_enable_v12,
	.rkiesharp_config = isp_rkiesharp_config_v12,
	.rkiesharp_enable = isp_ie_enable,
};

static struct rkisp_isp_params_v1x_config rkisp1_v10_isp_params_config = {
	.gamma_out_max_samples = 17,
	.hst_weight_grids_size = 28,
};

static struct rkisp_isp_params_v1x_config rkisp1_v12_isp_params_config = {
	.gamma_out_max_samples = 34,
	.hst_weight_grids_size = 81,
};

static __maybe_unused
void __isp_isr_other_config(struct rkisp_isp_params_vdev *params_vdev,
			    const struct rkisp1_isp_params_cfg *new_params)
{
	unsigned int module_en_update, module_cfg_update, module_ens;
	struct rkisp_isp_params_v1x_ops *ops =
		(struct rkisp_isp_params_v1x_ops *)params_vdev->priv_ops;
	struct ispsd_in_fmt *in_fmt = &params_vdev->dev->isp_sdev.in_fmt;
	bool ie_enable;
	bool iesharp_enable;
	bool is_grey_sensor;

	is_grey_sensor = in_fmt->mbus_code == MEDIA_BUS_FMT_Y8_1X8 ||
			 in_fmt->mbus_code == MEDIA_BUS_FMT_Y10_1X10 ||
			 in_fmt->mbus_code == MEDIA_BUS_FMT_Y12_1X12;

	module_en_update = new_params->module_en_update;
	module_cfg_update = new_params->module_cfg_update;
	module_ens = new_params->module_ens;

	ie_enable = !!(module_ens & CIFISP_MODULE_IE);
	iesharp_enable = !!(module_ens & CIFISP_MODULE_RK_IESHARP);
	if (ie_enable && iesharp_enable) {
		iesharp_enable = false;
		dev_err(params_vdev->dev->dev,
			"You can only use one mode in IE and RK_IESHARP!\n");
	}

	if ((module_en_update & CIFISP_MODULE_DPCC) ||
	    (module_cfg_update & CIFISP_MODULE_DPCC)) {
		/*update dpc config */
		if ((module_cfg_update & CIFISP_MODULE_DPCC))
			ops->dpcc_config(params_vdev,
					 &new_params->others.dpcc_config);

		if (module_en_update & CIFISP_MODULE_DPCC) {
			if (!!(module_ens & CIFISP_MODULE_DPCC))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_DPCC_MODE,
						   CIF_ISP_DPCC_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_DPCC_MODE,
						     CIF_ISP_DPCC_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_BLS) ||
	    (module_cfg_update & CIFISP_MODULE_BLS)) {
		/* update bls config */
		if ((module_cfg_update & CIFISP_MODULE_BLS))
			ops->bls_config(params_vdev, &new_params->others.bls_config);

		if (module_en_update & CIFISP_MODULE_BLS) {
			if (!!(module_ens & CIFISP_MODULE_BLS))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_BLS_CTRL,
						   CIF_ISP_BLS_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_BLS_CTRL,
						     CIF_ISP_BLS_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_SDG) ||
	    (module_cfg_update & CIFISP_MODULE_SDG)) {
		/* update sdg config */
		if ((module_cfg_update & CIFISP_MODULE_SDG))
			ops->sdg_config(params_vdev, &new_params->others.sdg_config);

		if (module_en_update & CIFISP_MODULE_SDG) {
			if (!!(module_ens & CIFISP_MODULE_SDG))
				isp_param_set_bits(params_vdev,
						CIF_ISP_CTRL,
						CIF_ISP_CTRL_ISP_GAMMA_IN_ENA);
			else
				isp_param_clear_bits(params_vdev,
						CIF_ISP_CTRL,
						CIF_ISP_CTRL_ISP_GAMMA_IN_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_LSC) ||
	    (module_cfg_update & CIFISP_MODULE_LSC)) {
		/* update lsc config */
		if ((module_cfg_update & CIFISP_MODULE_LSC))
			ops->lsc_config(params_vdev, &new_params->others.lsc_config);

		if (module_en_update & CIFISP_MODULE_LSC) {
			if (!!(module_ens & CIFISP_MODULE_LSC))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_LSC_CTRL,
						   CIF_ISP_LSC_CTRL_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_LSC_CTRL,
						     CIF_ISP_LSC_CTRL_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_AWB_GAIN) ||
	    (module_cfg_update & CIFISP_MODULE_AWB_GAIN)) {
		/* update awb gains */
		if ((module_cfg_update & CIFISP_MODULE_AWB_GAIN))
			ops->awb_gain_config(params_vdev,
					     &new_params->others.awb_gain_config);

		if (module_en_update & CIFISP_MODULE_AWB_GAIN) {
			if (!!(module_ens & CIFISP_MODULE_AWB_GAIN))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_CTRL,
						   CIF_ISP_CTRL_ISP_AWB_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_CTRL,
						     CIF_ISP_CTRL_ISP_AWB_ENA);
		}
	}

	if (((module_en_update & CIFISP_MODULE_BDM) ||
	     (module_cfg_update & CIFISP_MODULE_BDM)) &&
	    !is_grey_sensor) {
		/* update bdm config */
		if ((module_cfg_update & CIFISP_MODULE_BDM))
			ops->bdm_config(params_vdev, &new_params->others.bdm_config);

		if (module_en_update & CIFISP_MODULE_BDM) {
			if (!!(module_ens & CIFISP_MODULE_BDM))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_DEMOSAIC,
						   CIF_ISP_DEMOSAIC_BYPASS);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_DEMOSAIC,
						     CIF_ISP_DEMOSAIC_BYPASS);
		}
	}

	if ((module_en_update & CIFISP_MODULE_DEMOSAICLP) ||
	    (module_cfg_update & CIFISP_MODULE_DEMOSAICLP)) {
		/* update demosaiclp  config */
		if ((module_cfg_update & CIFISP_MODULE_DEMOSAICLP))
			ops->demosaiclp_config(params_vdev,
				&new_params->others.demosaiclp_config);

		if (module_en_update & CIFISP_MODULE_DEMOSAICLP)
			ops->demosaiclp_enable(params_vdev,
				!!(module_ens & CIFISP_MODULE_DEMOSAICLP));
	}

	if ((module_en_update & CIFISP_MODULE_FLT) ||
	    (module_cfg_update & CIFISP_MODULE_FLT)) {
		/* update filter config */
		if ((module_cfg_update & CIFISP_MODULE_FLT))
			ops->flt_config(params_vdev, &new_params->others.flt_config);

		if (module_en_update & CIFISP_MODULE_FLT) {
			if (!!(module_ens & CIFISP_MODULE_FLT))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_FILT_MODE,
						   CIF_ISP_FLT_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_FILT_MODE,
						     CIF_ISP_FLT_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_CTK) ||
	    (module_cfg_update & CIFISP_MODULE_CTK)) {
		/* update ctk config */
		if ((module_cfg_update & CIFISP_MODULE_CTK))
			ops->ctk_config(params_vdev, &new_params->others.ctk_config);

		if (module_en_update & CIFISP_MODULE_CTK)
			ops->ctk_enable(params_vdev,
					!!(module_ens & CIFISP_MODULE_CTK));
	}

	if ((module_en_update & CIFISP_MODULE_GOC) ||
	    (module_cfg_update & CIFISP_MODULE_GOC)) {
		/* update goc config */
		if ((module_cfg_update & CIFISP_MODULE_GOC))
			ops->goc_config(params_vdev, &new_params->others.goc_config);

		if (module_en_update & CIFISP_MODULE_GOC) {
			if (!!(module_ens & CIFISP_MODULE_GOC))
				isp_param_set_bits(params_vdev,
						CIF_ISP_CTRL,
						CIF_ISP_CTRL_ISP_GAMMA_OUT_ENA);
			else
				isp_param_clear_bits(params_vdev,
						CIF_ISP_CTRL,
						CIF_ISP_CTRL_ISP_GAMMA_OUT_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_CPROC) ||
	    (module_cfg_update & CIFISP_MODULE_CPROC)) {
		/* update cproc config */
		if ((module_cfg_update & CIFISP_MODULE_CPROC)) {
			ops->cproc_config(params_vdev,
					  &new_params->others.cproc_config);
		}
		if (module_en_update & CIFISP_MODULE_CPROC) {
			if (!!(module_ens & CIFISP_MODULE_CPROC))
				isp_param_set_bits(params_vdev,
						   CIF_C_PROC_CTRL,
						   CIF_C_PROC_CTR_ENABLE);
			else
				isp_param_clear_bits(params_vdev,
						   CIF_C_PROC_CTRL,
						   CIF_C_PROC_CTR_ENABLE);
		}
	}

	if (((module_en_update & CIFISP_MODULE_IE) ||
	     (module_cfg_update & CIFISP_MODULE_IE)) && ie_enable) {
		/* update ie config */
		if ((module_cfg_update & CIFISP_MODULE_IE))
			ops->ie_config(params_vdev, &new_params->others.ie_config);
	}

	if (((module_en_update & CIFISP_MODULE_RK_IESHARP) ||
	     (module_cfg_update & CIFISP_MODULE_RK_IESHARP)) && iesharp_enable) {
		/* update rkiesharp config */
		if ((module_cfg_update & CIFISP_MODULE_RK_IESHARP))
			ops->rkiesharp_config(params_vdev,
				&new_params->others.rkiesharp_config);
	}

	if (ie_enable || iesharp_enable)
		ops->ie_enable(params_vdev, true);
	else
		ops->ie_enable(params_vdev, false);

	if ((module_en_update & CIFISP_MODULE_DPF) ||
	    (module_cfg_update & CIFISP_MODULE_DPF)) {
		/* update dpf  config */
		if ((module_cfg_update & CIFISP_MODULE_DPF))
			ops->dpf_config(params_vdev, &new_params->others.dpf_config);

		if (module_en_update & CIFISP_MODULE_DPF) {
			if (!!(module_ens & CIFISP_MODULE_DPF))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_DPF_MODE,
						   CIF_ISP_DPF_MODE_EN);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_DPF_MODE,
						     CIF_ISP_DPF_MODE_EN);
		}
	}

	if ((module_en_update & CIFISP_MODULE_DPF_STRENGTH) ||
	    (module_cfg_update & CIFISP_MODULE_DPF_STRENGTH)) {
		/* update dpf strength config */
		ops->dpf_strength_config(params_vdev,
					 &new_params->others.dpf_strength_config);
	}

	if ((module_en_update & CIFISP_MODULE_WDR) ||
	    (module_cfg_update & CIFISP_MODULE_WDR)) {
		/* update wdr config */
		if ((module_cfg_update & CIFISP_MODULE_WDR))
			ops->wdr_config(params_vdev,
				&new_params->others.wdr_config);

		if (module_en_update & CIFISP_MODULE_WDR)
			ops->wdr_enable(params_vdev,
				       !!(module_ens & CIFISP_MODULE_WDR));
	}
}

static __maybe_unused
void __isp_isr_meas_config(struct rkisp_isp_params_vdev *params_vdev,
			   struct  rkisp1_isp_params_cfg *new_params)
{
	unsigned int module_en_update, module_cfg_update, module_ens;
	struct rkisp_isp_params_v1x_ops *ops =
		(struct rkisp_isp_params_v1x_ops *)params_vdev->priv_ops;

	module_en_update = new_params->module_en_update;
	module_cfg_update = new_params->module_cfg_update;
	module_ens = new_params->module_ens;

	if ((module_en_update & CIFISP_MODULE_AWB) ||
	    (module_cfg_update & CIFISP_MODULE_AWB)) {
		/* update awb config */
		if ((module_cfg_update & CIFISP_MODULE_AWB))
			ops->awb_meas_config(params_vdev,
					     &new_params->meas.awb_meas_config);

		if (module_en_update & CIFISP_MODULE_AWB)
			ops->awb_meas_enable(params_vdev,
					     &new_params->meas.awb_meas_config,
					     !!(module_ens & CIFISP_MODULE_AWB));
	}

	if ((module_en_update & CIFISP_MODULE_AFC) ||
	    (module_cfg_update & CIFISP_MODULE_AFC)) {
		/* update afc config */
		if ((module_cfg_update & CIFISP_MODULE_AFC))
			ops->afm_config(params_vdev, &new_params->meas.afc_config);

		if (module_en_update & CIFISP_MODULE_AFC) {
			if (!!(module_ens & CIFISP_MODULE_AFC))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_AFM_CTRL,
						   CIF_ISP_AFM_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_AFM_CTRL,
						     CIF_ISP_AFM_ENA);
		}
	}

	if ((module_en_update & CIFISP_MODULE_HST) ||
	    (module_cfg_update & CIFISP_MODULE_HST)) {
		/* update hst config */
		if ((module_cfg_update & CIFISP_MODULE_HST))
			ops->hst_config(params_vdev, &new_params->meas.hst_config);

		if (module_en_update & CIFISP_MODULE_HST)
			ops->hst_enable(params_vdev,
					&new_params->meas.hst_config,
					!!(module_ens & CIFISP_MODULE_HST));
	}

	if ((module_en_update & CIFISP_MODULE_AEC) ||
	    (module_cfg_update & CIFISP_MODULE_AEC)) {
		/* update aec config */
		if ((module_cfg_update & CIFISP_MODULE_AEC))
			ops->aec_config(params_vdev, &new_params->meas.aec_config);

		if (module_en_update & CIFISP_MODULE_AEC) {
			if (!!(module_ens & CIFISP_MODULE_AEC))
				isp_param_set_bits(params_vdev,
						   CIF_ISP_EXP_CTRL,
						   CIF_ISP_EXP_ENA);
			else
				isp_param_clear_bits(params_vdev,
						     CIF_ISP_EXP_CTRL,
						     CIF_ISP_EXP_ENA);
		}
	}
}

static __maybe_unused
void __preisp_isr_update_hdrae_para(struct rkisp_isp_params_vdev *params_vdev,
				    struct rkisp1_isp_params_cfg *new_params)
{
	struct preisp_hdrae_para_s *hdrae;
	struct cifisp_lsc_config *lsc;
	struct cifisp_awb_gain_config *awb_gain;
	unsigned int module_en_update, module_cfg_update, module_ens;
	int i, ret;

	hdrae = &params_vdev->hdrae_para;
	module_en_update = new_params->module_en_update;
	module_cfg_update = new_params->module_cfg_update;
	module_ens = new_params->module_ens;
	lsc = &new_params->others.lsc_config;
	awb_gain = &new_params->others.awb_gain_config;

	if (!params_vdev->dev->hdr.sensor)
		return;

	if ((module_en_update & CIFISP_MODULE_AWB_GAIN) ||
	    (module_cfg_update & CIFISP_MODULE_AWB_GAIN)) {
		/* update awb gains */
		if ((module_cfg_update & CIFISP_MODULE_AWB_GAIN)) {
			hdrae->r_gain = awb_gain->gain_red;
			hdrae->b_gain = awb_gain->gain_blue;
			hdrae->gr_gain = awb_gain->gain_green_r;
			hdrae->gb_gain = awb_gain->gain_green_b;
		}

		if (module_en_update & CIFISP_MODULE_AWB_GAIN) {
			if (!(module_ens & CIFISP_MODULE_AWB_GAIN)) {
				hdrae->r_gain = 0x0100;
				hdrae->b_gain = 0x0100;
				hdrae->gr_gain = 0x0100;
				hdrae->gb_gain = 0x0100;
			}
		}
	}

	if ((module_en_update & CIFISP_MODULE_LSC) ||
	    (module_cfg_update & CIFISP_MODULE_LSC)) {
		/* update lsc config */
		if ((module_cfg_update & CIFISP_MODULE_LSC))
			memcpy(hdrae->lsc_table, lsc->gr_data_tbl,
				PREISP_LSCTBL_SIZE);

		if (module_en_update & CIFISP_MODULE_LSC) {
			if (!(module_ens & CIFISP_MODULE_LSC))
				for (i = 0; i < PREISP_LSCTBL_SIZE; i++)
					hdrae->lsc_table[i] = 0x0400;
		}
	}

	ret = v4l2_subdev_call(params_vdev->dev->hdr.sensor, core, ioctl,
			       PREISP_CMD_SAVE_HDRAE_PARAM, hdrae);
	if (ret)
		params_vdev->dev->hdr.sensor = NULL;
}

static const struct cifisp_awb_meas_config awb_params_default_config = {
	{
		0, 0, RKISP_DEFAULT_WIDTH, RKISP_DEFAULT_HEIGHT
	},
	CIFISP_AWB_MODE_YCBCR, 200, 30, 20, 20, 0, 128, 128
};

static const struct cifisp_aec_config aec_params_default_config = {
	CIFISP_EXP_MEASURING_MODE_0,
	CIFISP_EXP_CTRL_AUTOSTOP_0,
	{
		RKISP_DEFAULT_WIDTH >> 2, RKISP_DEFAULT_HEIGHT >> 2,
		RKISP_DEFAULT_WIDTH >> 1, RKISP_DEFAULT_HEIGHT >> 1
	}
};

static const struct cifisp_hst_config hst_params_default_config = {
	CIFISP_HISTOGRAM_MODE_RGB_COMBINED,
	3,
	{
		RKISP_DEFAULT_WIDTH >> 2, RKISP_DEFAULT_HEIGHT >> 2,
		RKISP_DEFAULT_WIDTH >> 1, RKISP_DEFAULT_HEIGHT >> 1
	},
	{
		0, /* To be filled in with 0x01 at runtime. */
	}
};

static const struct cifisp_afc_config afc_params_default_config = {
	1,
	{
		{
			300, 225, 200, 150
		}
	},
	4,
	14
};

/* Not called when the camera active, thus not isr protection. */
static void rkisp1_params_first_cfg_v1x(struct rkisp_isp_params_vdev *params_vdev)
{
	struct rkisp_isp_params_v1x_ops *ops =
		(struct rkisp_isp_params_v1x_ops *)params_vdev->priv_ops;
	struct cifisp_hst_config hst = hst_params_default_config;
	struct device *dev = params_vdev->dev->dev;
	int i;

	spin_lock(&params_vdev->config_lock);

	ops->awb_meas_config(params_vdev, &awb_params_default_config);
	ops->awb_meas_enable(params_vdev, &awb_params_default_config, true);

	ops->aec_config(params_vdev, &aec_params_default_config);
	isp_param_set_bits(params_vdev, CIF_ISP_EXP_CTRL, CIF_ISP_EXP_ENA);

	ops->afm_config(params_vdev, &afc_params_default_config);
	isp_param_set_bits(params_vdev, CIF_ISP_AFM_CTRL, CIF_ISP_AFM_ENA);

	memset(hst.hist_weight, 0x01, sizeof(hst.hist_weight));
	ops->hst_config(params_vdev, &hst);
	if (params_vdev->dev->isp_ver == ISP_V12 ||
	    params_vdev->dev->isp_ver == ISP_V13) {
		isp_param_set_bits(params_vdev, CIF_ISP_HIST_CTRL_V12,
				   ~CIF_ISP_HIST_CTRL_MODE_MASK_V12 |
				   hst_params_default_config.mode);
	} else {
		isp_param_set_bits(params_vdev, CIF_ISP_HIST_PROP_V10,
				   ~CIF_ISP_HIST_PROP_MODE_MASK_V10 |
				   hst_params_default_config.mode);
	}

	/* disable color related config for grey sensor */
	if (params_vdev->in_mbus_code == MEDIA_BUS_FMT_Y8_1X8 ||
	    params_vdev->in_mbus_code == MEDIA_BUS_FMT_Y10_1X10 ||
	    params_vdev->in_mbus_code == MEDIA_BUS_FMT_Y12_1X12) {
		ops->ctk_enable(params_vdev, false);
		isp_param_clear_bits(params_vdev,
				     CIF_ISP_CTRL,
				     CIF_ISP_CTRL_ISP_AWB_ENA);
		isp_param_clear_bits(params_vdev,
				     CIF_ISP_LSC_CTRL,
				     CIF_ISP_LSC_CTRL_ENA);
	}

	params_vdev->hdrae_para.r_gain = 0x0100;
	params_vdev->hdrae_para.b_gain = 0x0100;
	params_vdev->hdrae_para.gr_gain = 0x0100;
	params_vdev->hdrae_para.gb_gain = 0x0100;
	for (i = 0; i < PREISP_LSCTBL_SIZE; i++)
		params_vdev->hdrae_para.lsc_table[i] = 0x0400;

	/* override the default things */
	if (!params_vdev->isp1x_params->module_cfg_update &&
	    !params_vdev->isp1x_params->module_en_update)
		dev_warn(dev, "can not get first iq setting in stream on\n");

	__isp_isr_other_config(params_vdev, params_vdev->isp1x_params);
	__isp_isr_meas_config(params_vdev, params_vdev->isp1x_params);
	__preisp_isr_update_hdrae_para(params_vdev, params_vdev->isp1x_params);

	spin_unlock(&params_vdev->config_lock);
}

static void rkisp1_save_first_param_v1x(struct rkisp_isp_params_vdev *params_vdev, void *param)
{
	struct rkisp1_isp_params_cfg *new_params;

	new_params = (struct rkisp1_isp_params_cfg *)param;
	*params_vdev->isp1x_params = *new_params;
}

static void rkisp1_clear_first_param_v1x(struct rkisp_isp_params_vdev *params_vdev)
{
	params_vdev->isp1x_params->module_cfg_update = 0;
	params_vdev->isp1x_params->module_en_update = 0;
}

static void
rkisp1_get_param_size_v1x(struct rkisp_isp_params_vdev *params_vdev, unsigned int sizes[])
{
	sizes[0] = sizeof(struct rkisp1_isp_params_cfg);
}

/* Not called when the camera active, thus not isr protection. */
static void rkisp1_params_disable_isp_v1x(struct rkisp_isp_params_vdev *params_vdev)
{
	struct rkisp_isp_params_v1x_ops *ops =
		(struct rkisp_isp_params_v1x_ops *)params_vdev->priv_ops;

	isp_param_clear_bits(params_vdev, CIF_ISP_DPCC_MODE, CIF_ISP_DPCC_ENA);
	isp_param_clear_bits(params_vdev, CIF_ISP_LSC_CTRL,
			     CIF_ISP_LSC_CTRL_ENA);
	isp_param_clear_bits(params_vdev, CIF_ISP_BLS_CTRL, CIF_ISP_BLS_ENA);
	isp_param_clear_bits(params_vdev, CIF_ISP_CTRL,
			     CIF_ISP_CTRL_ISP_GAMMA_IN_ENA);
	isp_param_clear_bits(params_vdev, CIF_ISP_CTRL,
			     CIF_ISP_CTRL_ISP_GAMMA_OUT_ENA);
	isp_param_clear_bits(params_vdev, CIF_ISP_DEMOSAIC,
			     CIF_ISP_DEMOSAIC_BYPASS);
	isp_param_clear_bits(params_vdev, CIF_ISP_FILT_MODE, CIF_ISP_FLT_ENA);
	ops->awb_meas_enable(params_vdev, NULL, false);
	isp_param_clear_bits(params_vdev, CIF_ISP_CTRL,
			     CIF_ISP_CTRL_ISP_AWB_ENA);
	isp_param_clear_bits(params_vdev, CIF_ISP_EXP_CTRL, CIF_ISP_EXP_ENA);
	ops->ctk_enable(params_vdev, false);
	isp_param_clear_bits(params_vdev, CIF_C_PROC_CTRL,
			     CIF_C_PROC_CTR_ENABLE);
	ops->hst_enable(params_vdev, NULL, false);
	isp_param_clear_bits(params_vdev, CIF_ISP_AFM_CTRL, CIF_ISP_AFM_ENA);
	ops->ie_enable(params_vdev, false);
	isp_param_clear_bits(params_vdev, CIF_ISP_DPF_MODE,
			     CIF_ISP_DPF_MODE_EN);
}

static void rkisp1_params_isr_v1x(struct rkisp_isp_params_vdev *params_vdev,
				  u32 isp_mis)
{
	struct rkisp1_isp_params_cfg *new_params;
	struct rkisp_buffer *cur_buf = NULL;
	unsigned int cur_frame_id =
		atomic_read(&params_vdev->dev->isp_sdev.frm_sync_seq) - 1;

	spin_lock(&params_vdev->config_lock);
	if (!params_vdev->streamon)
		goto unlock;

	/* get one empty buffer */
	if (!list_empty(&params_vdev->params))
		cur_buf = list_first_entry(&params_vdev->params,
					   struct rkisp_buffer, queue);
	if (!cur_buf)
		goto unlock;

	new_params = (struct rkisp1_isp_params_cfg *)(cur_buf->vaddr[0]);

	if (isp_mis & CIF_ISP_FRAME) {
		u32 isp_ctrl;

		list_del(&cur_buf->queue);

		__isp_isr_other_config(params_vdev, new_params);
		__isp_isr_meas_config(params_vdev, new_params);

		/* update shadow register immediately */
		isp_ctrl = rkisp1_ioread32(params_vdev, CIF_ISP_CTRL);
		isp_ctrl |= CIF_ISP_CTRL_ISP_CFG_UPD;
		rkisp1_iowrite32(params_vdev, isp_ctrl, CIF_ISP_CTRL);

		__preisp_isr_update_hdrae_para(params_vdev, new_params);

		cur_buf->vb.sequence = cur_frame_id;
		vb2_buffer_done(&cur_buf->vb.vb2_buf, VB2_BUF_STATE_DONE);
	}
unlock:
	spin_unlock(&params_vdev->config_lock);
}

static struct rkisp_isp_params_ops rkisp_isp_params_ops_tbl = {
	.save_first_param = rkisp1_save_first_param_v1x,
	.clear_first_param = rkisp1_clear_first_param_v1x,
	.get_param_size = rkisp1_get_param_size_v1x,
	.first_cfg = rkisp1_params_first_cfg_v1x,
	.disable_isp = rkisp1_params_disable_isp_v1x,
	.isr_hdl = rkisp1_params_isr_v1x,
};

int rkisp_init_params_vdev_v1x(struct rkisp_isp_params_vdev *params_vdev)
{
	params_vdev->ops = &rkisp_isp_params_ops_tbl;
	if (params_vdev->dev->isp_ver == ISP_V12 ||
	    params_vdev->dev->isp_ver == ISP_V13) {
		params_vdev->priv_ops = &rkisp1_v12_isp_params_ops;
		params_vdev->priv_cfg = &rkisp1_v12_isp_params_config;
	} else {
		params_vdev->priv_ops = &rkisp1_v10_isp_params_ops;
		params_vdev->priv_cfg = &rkisp1_v10_isp_params_config;
	}

	params_vdev->isp1x_params = vmalloc(sizeof(*params_vdev->isp1x_params));
	if (!params_vdev->isp1x_params)
		return -ENOMEM;

	rkisp1_clear_first_param_v1x(params_vdev);

	return 0;
}

void rkisp_uninit_params_vdev_v1x(struct rkisp_isp_params_vdev *params_vdev)
{
	vfree(params_vdev->isp1x_params);
}